Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.92)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1j7SaP-0000gh-55
	for pgsql-committers@arkaria.postgresql.org; Thu, 27 Feb 2020 23:28:57 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1j7SaN-0003ac-Qr
	for pgsql-committers@arkaria.postgresql.org; Thu, 27 Feb 2020 23:28:55 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql@j-davis.com>)
	id 1j7SaN-0003aV-Gq
	for pgsql-committers@lists.postgresql.org; Thu, 27 Feb 2020 23:28:55 +0000
Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <pgsql@j-davis.com>)
	id 1j7SaL-00017P-0k
	for pgsql-committers@lists.postgresql.org; Thu, 27 Feb 2020 23:28:55 +0000
Received: by mail-pj1-x1043.google.com with SMTP id e9so452213pjr.4
        for <pgsql-committers@lists.postgresql.org>;
 Thu, 27 Feb 2020 15:28:52 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=j-davis-com.20150623.gappssmtp.com; s=20150623;
        h=message-id:subject:from:to:cc:date:in-reply-to:references
         :mime-version:content-transfer-encoding;
        bh=588imnafVDA5w2thehqfTjtUMgpyvEJ7soRdLPMfmeM=;
        b=nUCM+jwWWq2ZLPVapww2/Znqu6eBWEWclGsri9utNbi83AoM3zFliX4mFfiTgWxmgA
         vL0EVp74KOurwcppYWUuz5GBMLX8Ozl9gILIiOs3q3mxVNJ5fxlPA1PLNakOvDmJIOla
         OMp6m92BGOisjc7KFvX7uztIjsrZjfDf14hMCIy7w8bvCZsplnXOL2O7RsPN1r+7G/dC
         IRMTEwEgEpDyehufmQou5coYgSeQ5BYwm0EInFHbOYT+py4wLIellyzvn265ODbkGQRg
         4Z3TBEOfd4OxBuJjQvYiiBpdqNPGgOi+SUnZSjdox0/vEDuMZi7zqDiwVPwL/kqBpFcD
         1/Rg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
         :references:mime-version:content-transfer-encoding;
        bh=588imnafVDA5w2thehqfTjtUMgpyvEJ7soRdLPMfmeM=;
        b=H7Eemxmiis+U0I0UX692eRoVa8mxsXXuxHlHbT/nj2Gj7nEvCLOeZLG/YAm0mfloC1
         n38QveWJfzUnL9D4vGP9tYcyRuG1IWYjVjjDCFQHxC04ABPcPGS7FN/x+RSSuerm07Iy
         W/kqd76q7jSSF0j6RycESG1mrkyoZuoPteGnp6O3m6hoB6fQDTwopWUHGM6vf9CsT5lT
         P0MHmjvfYwGxQfJk14UkKIKlE7HjYjUEdYdc/gKmPhZVQl9skd0Mi0VCHD0pMgxxWPHx
         d1DS0ibMRqTrrMnlDrTKsKSI5+2Z1ebDvrMjPDTe9xl4cGCDegdMcsBb3QrhtGjkONUM
         H18A==
X-Gm-Message-State: APjAAAWQM7V5/LTHt/y1Pg9Xb1Q10u535bsPQ8oNYOvTCQU0MyP/EKR+
	i/exr9Rb6mR2r60zN+LIPn+DWQ==
X-Google-Smtp-Source: 
 APXvYqxnQGNcfyLvto5amVQMwjnQI7oGnmzT9uwC/7ZY66HvaKvfgOxz4pgj+MceddwJdu4pjFW22w==
X-Received: by 2002:a17:902:868e:: with SMTP id
 g14mr1183873plo.87.1582846131136;
        Thu, 27 Feb 2020 15:28:51 -0800 (PST)
Received: from jdavis ([2600:1010:b04d:ab6c:29e5:f88:1fdd:98f6])
        by smtp.gmail.com with ESMTPSA id
 c15sm7432393pgk.66.2020.02.27.15.28.49
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Thu, 27 Feb 2020 15:28:50 -0800 (PST)
Message-ID: <0d6f3e77dc0c02ee4ab44dff3c8b15ac8f06f99a.camel@j-davis.com>
Subject: Re: pgsql: Save calculated transitionSpace in Agg node.
From: Jeff Davis <pgsql@j-davis.com>
To: Tom Lane <tgl@sss.pgh.pa.us>, Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Date: Thu, 27 Feb 2020 15:28:47 -0800
In-Reply-To: <12491.1582833409@sss.pgh.pa.us>
References: <E1j7Opv-0002yK-8q@gemulon.postgresql.org>
	 <12491.1582833409@sss.pgh.pa.us>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

On Thu, 2020-02-27 at 14:56 -0500, Tom Lane wrote:
> Jeff Davis <jdavis@postgresql.org> writes:
> > Save calculated transitionSpace in Agg node.
> 
> Surely this patch is a few bricks shy of a load.  Don't you need
> copyfuncs/readfuncs/outfuncs support, for starters?

Sorry, I will fix it.

I was looking at whether changes to copyfuncs (etc.) should also cause
a catversion bump, and it seems inconsistent. Commit 9ce77d75 does, but
6ef77cf4 does not. Any particular rules around that? Not terribly
important as the catversion was just bumped anyway; just curious.

Regards,
	Jeff Davis