Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paKZE-00045Z-Gz for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Mar 2023 18:00:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1paKZD-0008Sy-DP for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Mar 2023 18:00:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1paKZD-0008Sp-4b for pgsql-hackers@lists.postgresql.org; Thu, 09 Mar 2023 18:00:39 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1paKZA-0008JO-Lq for pgsql-hackers@lists.postgresql.org; Thu, 09 Mar 2023 18:00:38 +0000 Received: by mail-wm1-x333.google.com with SMTP id j3so1770632wms.2 for ; Thu, 09 Mar 2023 10:00:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1678384835; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2gVhKqwWhivf9jDW3CKKTQbDXKk2eMhvkxBurR9HONE=; b=c3mbQ7wwOXbRlJ6Z2lBwvSfOhAOqABLB4NFNBDwgjAfuVxgOZjMywHFzBJMnSvW+f0 3e97UVbDs+jpkuRYSSlH5WKXRwyS1YMd6IhmVC4+UdpU6zWrUeAuPyuv8wwBzIcDT1fq Qh+aiFKtlQaClH4/y5xe5jjrntDWkQcbMH6TjfbolbGP29HT2ylPybybkoN1g8phnSsa GUB3XdDbAgxsGgGJHYnhDb3GN79MLtpoBFJVuLHS1MDZUxMl4CRht4mD3xWtUa0NhXsQ ITnChQavBqhNBDpghM+1ftZumcT6yoJA5lQZBhhPCjDts+U7dAsUZ4ngxR5HENGHOmUw rrBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678384835; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2gVhKqwWhivf9jDW3CKKTQbDXKk2eMhvkxBurR9HONE=; b=L010de7dHALKHRZyWlP7Y0m5SYcYLhRAqWRQXD9iJB7ULTZX1xXfFlxaEpvxwawFTr vLIhFzXdODqepbwtSp6tRFCsA7FJSQ+1us90MRQqE8JNtnMasa/uS6o898ym1S8UAB53 ekRiCDtdv3mvN+nbQSv+kXEecl+Jy9QrH3IbcoeSjXnWZu3Bv4PnexJxVectRlGhD2xS kknMkZWjX2eEG3X7ECIf7qpAJ3TEeKWd4hQ0eIl2h4SDG45UYLuZhZmOOiQtCiHvazzG 6eW2eYAUgbQcGZOVM/v9nCHZyR4E9KOe8Y+tUOiCtsSFD4FF7+Bxs75pgYgQKb1OBS35 EsKw== X-Gm-Message-State: AO0yUKWtz/J9c55XEYxfahFQUL9x0moOsEJedXxGR2Dra4WzTE7gWkeE aPo9f3BkVcKpW3CKUQoepmJRjHrfyFdv0Ys6036TjU9cqqBFn2wXgGcU5Gfd/VW5A31QKUaOBWh kEGc5Re+el0P5svQXR2j7YP9zDiY9V8vfy2HbNu7fFipACIzxQqmqIOKSMNcVKXTjr7SQZASyX1 dJtG8pORpjxObx1//hY3dv9lONnEkr9R4kmBvN+c7YtLGAvxlIRTEI X-Google-Smtp-Source: AK7set+KFmmDGU2j+2BeJLhry2Qs0GgPRLakTCFlRbY/z/S033bSPSxjAM0AJy0JlsQV9rEYeHrNvA== X-Received: by 2002:a05:600c:458d:b0:3eb:383c:187d with SMTP id r13-20020a05600c458d00b003eb383c187dmr96541wmo.27.1678384835259; Thu, 09 Mar 2023 10:00:35 -0800 (PST) Received: from [10.137.0.17] (xdsl.62.192.157.70.srvc.fr. [62.192.157.70]) by smtp.gmail.com with ESMTPSA id l10-20020a05600012ca00b002c70851fdd8sm8710wrx.75.2023.03.09.10.00.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Mar 2023 10:00:35 -0800 (PST) Message-ID: <0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com> Date: Thu, 9 Mar 2023 19:00:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump) Content-Language: en-US To: Michael Paquier Cc: Daniel Gustafsson , Christoph Berg , Tomas Vondra , PostgreSQL Hackers References: <819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com> From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/9/23 01:30, Michael Paquier wrote: > On Thu, Mar 09, 2023 at 12:39:08AM +0100, Tomas Vondra wrote: >> IMO we should fix that. We have a bunch of buildfarm members running on >> Ubuntu 18.04 (or older) - it's true none of them seems to be running TAP >> tests. But considering how trivial the fix is ... >> >> Barring objections, I'll push a fix early next week. > > +1, better to change that, thanks. Actually, would --rm be OK even on > Windows? As far as I can see, the CI detects a LZ4 command for the > VS2019 environment but not the liblz4 libraries that would be needed > to trigger the set of tests. Thanks for noticing that. I'll investigate next week. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company