Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f5wb5-0008TT-Mf for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Apr 2018 16:58:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f5wb3-0007wQ-RL for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Apr 2018 16:58:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f5wb3-0007wG-KI for pgsql-hackers@lists.postgresql.org; Tue, 10 Apr 2018 16:58:17 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f5wb0-0003Pb-SK for pgsql-hackers@postgresql.org; Tue, 10 Apr 2018 16:58:17 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w3AGwAc5010010; Tue, 10 Apr 2018 12:58:10 -0400 From: Tom Lane To: Julien Rouhaud cc: Michael Paquier , Postgres hackers Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers. In-reply-to: References: <20180409010031.GA11599@paquier.xyz> <16609.1523243109@sss.pgh.pa.us> <20180409061354.GD1740@paquier.xyz> <6629.1523294509@sss.pgh.pa.us> <17755.1523306794@sss.pgh.pa.us> <17165.1523367992@sss.pgh.pa.us> Comments: In-reply-to Julien Rouhaud message dated "Tue, 10 Apr 2018 18:13:01 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <10008.1523379490.1@sss.pgh.pa.us> Date: Tue, 10 Apr 2018 12:58:10 -0400 Message-ID: <10009.1523379490@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Julien Rouhaud writes: > On Tue, Apr 10, 2018 at 3:46 PM, Tom Lane wrote: >> Hm. I wonder if we don't also want NO_TEMP_INSTALL, like the doc/src/sgml >> makefile. I don't know whether "make check" could be useful in a PGXS >> build, but certainly that recipe for making a temp install isn't gonna >> work. > If I understand correctly, PGXS.mk already forbids a "make check" if > PGXS is defined. And it seems that postgres' contribs rely on > including PGXS.mk, setting NO_PGXS and doing a "make check", so > NO_TEMP_INSTALL shouldn't be needed. Well, the question that's bothering me is how come "make check" in an external build doesn't try to execute the temp-install rule before printing that error message. Experimentation shows that it doesn't, but it sure looks to me like it should: there's nothing conditional about the "check: temp-install" dependency in Makefile.global. And none of the three if-guards in the temp-install rule itself should prevent this, so what is preventing it? I don't see it. For this reason, I thought that adding NO_TEMP_INSTALL would be a good safety factor in case somebody changes/breaks whatever unobvious thing is keeping this from failing, and so I went ahead and did it. regards, tom lane