Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nF600-0000Lm-SK for pgsql-committers@arkaria.postgresql.org; Wed, 02 Feb 2022 03:08:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nF5zz-0008De-B4 for pgsql-committers@arkaria.postgresql.org; Wed, 02 Feb 2022 03:07:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nF5zy-0008DP-Vz for pgsql-committers@lists.postgresql.org; Wed, 02 Feb 2022 03:07:58 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nF5zw-00064O-4Z for pgsql-committers@lists.postgresql.org; Wed, 02 Feb 2022 03:07:57 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21237r2v1052580; Tue, 1 Feb 2022 22:07:53 -0500 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org, Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai In-reply-to: <20220131203125.xg2cz33g2xenayy5@alap3.anarazel.de> References: <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de> <535668.1643594467@sss.pgh.pa.us> <20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de> <829537.1643659710@sss.pgh.pa.us> <20220131203125.xg2cz33g2xenayy5@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Mon, 31 Jan 2022 12:31:25 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1052578.1643771273.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Tue, 01 Feb 2022 22:07:53 -0500 Message-ID: <1052579.1643771273@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-01-31 15:08:30 -0500, Tom Lane wrote: >> Done now. > Thanks! Just for the archives' sake --- seems this broke pademelon [1]: cc -Ae -g +O0 -Wp,-H16384 +Z -I. -I. -I../../../src/include -D_XOPEN_SOUR= CE_EXTENDED -I/usr/local/libxml2-2.6.23/include/libxml2 -I/usr/local/incl= ude -DDEBUGGING -I/opt/perl5.8.9/lib/5.8.9/PA-RISC2.0-multi/CORE -c -o p= lperl.o plperl.c ... cc: "plperl.c", line 669: error 1000: Unexpected symbol: "do". cc: "plperl.c", line 669: error 1000: Unexpected symbol: "_sv". cc: error 2017: Cannot recover from earlier errors, terminating. make[3]: *** [plperl.o] Error 1 I've not tried to trace that in detail, but it seems clear that something in the newer ppport.h is assuming a C99-compliant compiler. I can hardly blame the Perl guys for assuming that in 2022, so I'm just going to remove --with-perl from that animal. (It appears that Python 3 assumes C99-compliance too, in a different way [2], so I've also had to remove --with-python. Maybe I could resurrect that if I built Python 2.7 on that machine, but I don't think I'm going to summon the motivation. The world has clearly Moved On from pre-C99 compilers.) regards, tom lane [1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dpademelon&dt= =3D2022-02-02%2000%3A47%3A30 [2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dpademelon&dt= =3D2022-02-02%2000%3A21%3A18