Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akbYM-0007wK-Ui for pgsql-committers@arkaria.postgresql.org; Mon, 28 Mar 2016 18:06:15 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1akbYM-0005xL-G7 for pgsql-committers@arkaria.postgresql.org; Mon, 28 Mar 2016 18:06:14 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1akbYL-0005xE-Ug for pgsql-committers@postgresql.org; Mon, 28 Mar 2016 18:06:14 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1akbYJ-0003sR-AV for pgsql-committers@postgresql.org; Mon, 28 Mar 2016 18:06:12 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id u2SI677M010552; Mon, 28 Mar 2016 14:06:07 -0400 From: Tom Lane To: Alvaro Herrera cc: pgsql-committers@postgresql.org Subject: Re: pgsql: Improve internationalization of messages involving type names In-reply-to: References: Comments: In-reply-to Alvaro Herrera message dated "Mon, 28 Mar 2016 17:25:19 -0000" Date: Mon, 28 Mar 2016 14:06:07 -0400 Message-ID: <10551.1459188367@sss.pgh.pa.us> X-Pg-Spam-Score: -2.9 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org Alvaro Herrera writes: > Also, change them all to use the same quoting convention, namely that > the function name is not to be quoted but the type name is. (I'm not > quite sure why this is so, but it's the clear majority.) Actually, I think the general convention is to NOT quote type names in error messages. Certainly that's so when using format_type_be() to produce a name for a not-known-at-compile-time type. I would argue that these messages should be written to look the same as if format_type_be() had been used, and that would mean leaving off the quotes. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers