Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDnY4-0000t6-TZ for pgsql-committers@arkaria.postgresql.org; Tue, 19 Jul 2022 13:46:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oDnY3-0001od-HO for pgsql-committers@arkaria.postgresql.org; Tue, 19 Jul 2022 13:46:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDnY3-0001oU-AU for pgsql-committers@lists.postgresql.org; Tue, 19 Jul 2022 13:46:03 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oDnXw-0003QS-Vf for pgsql-committers@lists.postgresql.org; Tue, 19 Jul 2022 13:46:02 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26JDjqfC1057667; Tue, 19 Jul 2022 09:45:52 -0400 From: Tom Lane To: Alvaro Herrera cc: Pavel Stehule , Andres Freund , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi In-reply-to: <20220719131801.xltj7tupafzkj5dx@alvherre.pgsql> References: <20220719131801.xltj7tupafzkj5dx@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Tue, 19 Jul 2022 15:18:01 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1057665.1658238352.1@sss.pgh.pa.us> Date: Tue, 19 Jul 2022 09:45:52 -0400 Message-ID: <1057666.1658238352@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alvaro Herrera writes: > On 2022-Jul-19, Pavel Stehule wrote: >> Unfortunately, this commit definitely breaks plpgsql_check. Can the >> following routines be visible? > Do you just need to send a patch to add an exports.txt file to > src/pl/plpgsql/src/ for these functions? The precedent of plpython says that PGDLLEXPORT markers are sufficient. But yeah, we need a list of exactly which functions need to be re-exposed. I imagine pldebugger has its own needs. regards, tom lane