From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Peter Geoghegan <pg@heroku.com>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO
 NOTHING/UPDATE.
In-reply-to: <20150521011229.GX27868@alap3.anarazel.de>
References: <E1YqZCW-0000e6-Od@gemulon.postgresql.org>
 <20150520215816.GI5885@postgresql.org>
 <CAM3SWZRUhr1806zsF28CVRrB=b4t8PWv8d9x29z02xTQoFDyWA@mail.gmail.com>
 <20150520220911.GK5885@postgresql.org>
 <CAM3SWZQXP3Z=iXQ_+HwoqG7417JYf6HKDTmgk-4Xt05OEL_S_Q@mail.gmail.com>
 <CAM3SWZT0Rex4CpZo+re_m2Dh7wunMNsbD-9ZSWWx=JSewW3OVg@mail.gmail.com>
 <20150521011229.GX27868@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
 message dated "Thu, 21 May 2015 03:12:29 +0200"
Date: Wed, 20 May 2015 21:22:08 -0400
Message-ID: <10660.1432171328@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Andres Freund <andres@anarazel.de> writes:
> You realize there's other instances of this in the same damn function?

Not to mention that several places in libpq/fe-exec.c should be
taught about this new tag.  And who-knows-what in other client-side
libraries.  I am not really sure that it was a good idea to invent
this command tag.  In fact, I'm pretty sure it was a *bad* idea ---
what will happen if we ever create a statement actually named UPSERT?

I think we should fix this by ripping out the variant tag, not trying
to propagate it everywhere it would need to go.  Cute ideas are not
the same as good ideas.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers