Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1f2JSj-0001LE-2g
	for pgsql-committers@arkaria.postgresql.org; Sat, 31 Mar 2018 16:34:41 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1f2JSh-0003dj-QX
	for pgsql-committers@arkaria.postgresql.org; Sat, 31 Mar 2018 16:34:39 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1f2JSh-0003da-IE
	for pgsql-committers@lists.postgresql.org; Sat, 31 Mar 2018 16:34:39 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1f2JSe-0000zV-6P
	for pgsql-committers@lists.postgresql.org; Sat, 31 Mar 2018 16:34:38 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w2VGYWQC010687;
	Sat, 31 Mar 2018 12:34:33 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
cc: Teodor Sigaev <teodor@sigaev.ru>, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set random seed for pgbench.
In-reply-to: <alpine.DEB.2.20.1803310828100.23311@lancre>
References: <E1f0U1H-00005J-98@gemulon.postgresql.org>
 <32390.1522464534@sss.pgh.pa.us> <alpine.DEB.2.20.1803310828100.23311@lancre>
Comments: In-reply-to Fabien COELHO <coelho@cri.ensmp.fr>
	message dated "Sat, 31 Mar 2018 09:00:02 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <10685.1522514072.1@sss.pgh.pa.us>
Date: Sat, 31 Mar 2018 12:34:32 -0400
Message-ID: <10686.1522514072@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Fabien COELHO <coelho@cri.ensmp.fr> writes:
>> So this patch has ignored the possibility of not having pg_strong_random.

> I assumed that pg_strong_random is always available,

... which is wrong.  Every other call of it is wrapped in
#ifdef HAVE_STRONG_RANDOM, and so must this one be.
We can use the same error message though, I suppose.

Adjusted and pushed.

			regards, tom lane