From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Noah Misch <noah@leadboat.com>, Thomas Munro <thomas.munro@gmail.com>,
        pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl
 start" f
In-reply-to: <926839.1642708567@sss.pgh.pa.us>
References: <E1nAIWI-0006et-HW@gemulon.postgresql.org>
 <CA+hUKGKV6fOHvfiPt8=dOKzvswjAyLoFoJF1iQXMNpi7+hD1JQ@mail.gmail.com>
 <855583.1642687119@sss.pgh.pa.us> <867290.1642689136@sss.pgh.pa.us>
 <20220120192736.msyesvdlljn6tptw@alap3.anarazel.de>
 <926839.1642708567@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 20 Jan 2022 14:56:07 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1075552.1642717844.1@sss.pgh.pa.us>
Date: Thu, 20 Jan 2022 17:30:44 -0500
Message-ID: <1075553.1642717844@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1075553.1642717844%40sss.pgh.pa.us>
Precedence: bulk

I wrote:
> What I'm thinking of doing is inventing a "soft_stop" variant of
> Cluster::stop that won't complain if pg_ctl stop fails, and then
> having 017_shm's poll_start() call that before retrying the start
> call.

I did that, modeling the details on Cluster::start's fail_ok option.

> It seems like it'd also be a good idea if the END block used
> soft_stop instead of regular stop.

I still like this idea, but I left it alone for the moment,
figuring I've used up my quota of buildfarm destabilization
for now.

			regards, tom lane