From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: Mark Dilger <mark.dilger@enterprisedb.com>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Generalize hash and ordering support in amapi
In-reply-to: <0f6a8a8a-b42e-433b-89cd-ee121d0919b3@eisentraut.org>
References: <E1tngY6-0000UL-2n@gemulon.postgresql.org>
 <2557074.1740673653@sss.pgh.pa.us>
 <CAHgHdKuCQ3Dh8wt9QxWRmezgE62qzYW86T9Mv1n5s3fOJ4G2dQ@mail.gmail.com>
 <1789fe14-c19d-4025-9201-0eb8faa0840b@eisentraut.org>
 <165328.1741109742@sss.pgh.pa.us>
 <0f6a8a8a-b42e-433b-89cd-ee121d0919b3@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Fri, 07 Mar 2025 12:05:53 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1113683.1741373446.1@sss.pgh.pa.us>
Date: Fri, 07 Mar 2025 13:50:46 -0500
Message-ID: <1113684.1741373446@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1113684.1741373446%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> I have committed fixes for these issues along the lines you suggested.

Thanks.  There is a typo in hashhandler:

-   amroutine->amcancrosscompare = true;
+   amroutine->amconsistentequality = true;
+   amroutine->amconsistentequality = false;

The second line should be setting amconsistentordering = false.

Also, may I suggest one more thing?  I think the test in
comparison_ops_are_compatible should be just

-           if (amroutine->amcanorder && amroutine->amconsistentordering)
+           if (amroutine->amconsistentordering)

(and the comment for it needs adjustment too).  To my mind,
amconsistentordering is a static declaration that operators
within one of the AM's opfamilies are expected to have this
property.  That could be true whether or not the AM is capable
of returning tuples in order.  So although these flags might
commonly be set together, I think they are independent
properties.

			regards, tom lane