Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMtzE-00034j-61 for pgsql-committers@arkaria.postgresql.org; Tue, 31 Jan 2023 17:00:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pMtzD-0006I9-36 for pgsql-committers@arkaria.postgresql.org; Tue, 31 Jan 2023 16:59:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMtzC-0006Hz-RR for pgsql-committers@lists.postgresql.org; Tue, 31 Jan 2023 16:59:58 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMtzA-0000rh-RA for pgsql-committers@lists.postgresql.org; Tue, 31 Jan 2023 16:59:58 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30VGxsLT1135791; Tue, 31 Jan 2023 11:59:54 -0500 From: Tom Lane To: Robins Tharakan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Make Vars be outer-join-aware. In-reply-to: References: Comments: In-reply-to Robins Tharakan message dated "Tue, 31 Jan 2023 17:54:40 +1030" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1135789.1675184394.1@sss.pgh.pa.us> Date: Tue, 31 Jan 2023 11:59:54 -0500 Message-ID: <1135790.1675184394@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robins Tharakan writes: > Since this commit, my test setup is triggering asserts every few minutes. I concluded that assert was just wrong, and removed it. Maybe there is some weaker assertion we could make, but it'd require passing down more context than fix_scan_expr gets now, and it doesn't seem worth the trouble. Thanks for the report! regards, tom lane