Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rsZka-007vrl-2O for pgsql-committers@arkaria.postgresql.org; Fri, 05 Apr 2024 02:56:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rsZkZ-00Fjvw-4Q for pgsql-committers@arkaria.postgresql.org; Fri, 05 Apr 2024 02:56:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rsZkY-00Fju9-Sa for pgsql-committers@lists.postgresql.org; Fri, 05 Apr 2024 02:56:18 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rsZkW-000iA9-Fn for pgsql-committers@lists.postgresql.org; Fri, 05 Apr 2024 02:56:18 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 4352uD4j1164535; Thu, 4 Apr 2024 22:56:13 -0400 From: Tom Lane To: Amit Langote cc: Andrew Dunstan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Add basic JSON_TABLE() functionality In-reply-to: References: <49c3a0cc-2998-4e25-8bc3-e70b3cba87eb@dunslane.net> <601996.1712244407@sss.pgh.pa.us> <603615.1712245382@sss.pgh.pa.us> <655689.1712249708@sss.pgh.pa.us> Comments: In-reply-to Amit Langote message dated "Fri, 05 Apr 2024 11:52:33 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1164533.1712285773.1@sss.pgh.pa.us> Date: Thu, 04 Apr 2024 22:56:13 -0400 Message-ID: <1164534.1712285773@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Amit Langote writes: > Wonder if, for consistency, I should change the coding so that the > FEATURE_NOT_SUPPORTED is reported in transformJsonTable() or > something? Consistency with what? There are plenty of other gram.y productions that throw FEATURE_NOT_SUPPORTED conditionally. regards, tom lane