Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1vcYf1-008Jlg-13
	for pgsql-committers@arkaria.postgresql.org;
	Mon, 05 Jan 2026 00:41:28 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1vcYez-00Gbq2-2f
	for pgsql-committers@arkaria.postgresql.org;
	Mon, 05 Jan 2026 00:41:26 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vcYez-00Gbpu-1q
	for pgsql-committers@lists.postgresql.org;
	Mon, 05 Jan 2026 00:41:26 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1vcYey-004EW7-2r
	for pgsql-committers@lists.postgresql.org;
	Mon, 05 Jan 2026 00:41:25 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 6050fNhh1193765;
	Sun, 4 Jan 2026 19:41:23 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove unneeded defines from pg_config.h.in
In-reply-to: <E1vcYUU-004XVb-1O@gemulon.postgresql.org>
References: <E1vcYUU-004XVb-1O@gemulon.postgresql.org>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 05 Jan 2026 00:30:35 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1193763.1767573683.1@sss.pgh.pa.us>
Date: Sun, 04 Jan 2026 19:41:23 -0500
Message-ID: <1193764.1767573683@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/1193764.1767573683%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Remove unneeded defines from pg_config.h.in
> This commit removes HAVE_ATOMIC_H and HAVE_MBARRIER_H from
> pg_config.h.in, cleanup that could have been done in 25f36066dd2a.

This patch is not okay.  pg_config.h.in is a generated file and
hand modifications in it will not do.

If we don't need these symbols anymore, the right fix is to remove
the probes for these headers in the autoconf and meson scripts.

			regards, tom lane