Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myFLe-0007rX-S7 for pgsql-committers@arkaria.postgresql.org; Fri, 17 Dec 2021 15:40:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1myFLd-0006qw-D8 for pgsql-committers@arkaria.postgresql.org; Fri, 17 Dec 2021 15:40:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myFLd-0006qn-65 for pgsql-committers@lists.postgresql.org; Fri, 17 Dec 2021 15:40:41 +0000 Received: from smtp-190a.mail.infomaniak.ch ([185.125.25.10]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myFLZ-0008L3-W7 for pgsql-committers@lists.postgresql.org; Fri, 17 Dec 2021 15:40:40 +0000 Received: from smtp-2-0000.mail.infomaniak.ch (unknown [10.5.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4JFtVB0xh2zMqDB6 for ; Fri, 17 Dec 2021 16:40:34 +0100 (CET) Received: from [IPV6:2a01:e0a:1d3:9921:2732:e5f6:8239:a200] (unknown [IPV6:2a01:e0a:1d3:9921:2732:e5f6:8239:a200]) by smtp-2-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4JFtV96k4tzlhfPL for ; Fri, 17 Dec 2021 16:40:33 +0100 (CET) Message-ID: <119eacbf-2f89-7f26-a0f3-71adff4ccbcc@anayrat.info> Date: Fri, 17 Dec 2021 16:40:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Content-Language: en-GB-large To: pgsql-committers@lists.postgresql.org References: From: Adrien Nayrat Subject: Re: pgsql: Remove pg_dump's --no-synchronized-snapshots switch. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 12/16/21 00:45, Tom Lane wrote: > Remove pg_dump's --no-synchronized-snapshots switch. > > Server versions for which there was a plausible reason to > use this switch are all out of support now. Leaving it > around would accomplish little except to let careless DBAs > shoot themselves in the foot. > > Discussion: https://postgr.es/m/556122.1639520324@sss.pgh.pa.us > Hello, I have seen one situation where this option could have been useful even on recent Postgres version: Few years ago, I have seen an instance hit wraparound (1 million transactions left) due to a bug (vacuum didn't freeze some blocks, bug has been fixed since). I had to perform a dump/restore, but can't use parallel dump as Postgres refused to export transaction snapshot. So the dump was ... long. Late in the night, I didn't notice I could have used --no-synchronized-snapshots to perform parallel dump. As Postgres didn't accept new transaction, there was no risk of incoherent dump. I don't know if we should keep this option. I just want to share a case where this option could have been useful. Regards, -- Adrien