From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: pgsql: Build src/port files as a library with -fPIC, and use that
 in li
To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-committers@lists.postgresql.org
References: <E1g5Y8r-0006vs-QA@gemulon.postgresql.org>
Message-ID: <11d432a5-659e-81da-3722-513d039515e1@2ndQuadrant.com>
Date: Fri, 28 Sep 2018 09:51:51 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <E1g5Y8r-0006vs-QA@gemulon.postgresql.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-MW
Precedence: bulk


On 09/27/2018 11:23 AM, Tom Lane wrote:
> Build src/port files as a library with -fPIC, and use that in libpq.
>
> libpq and ecpg need shared-library-friendly versions of assorted src/port/
> and src/common/ modules.  Up to now, they got those by symlinking the
> individual source files and compiling them locally.  That's baroque, and a
> pain to maintain, and it results in some amount of duplicated compile work.
> It might've made sense when only a couple of files were needed, but the
> list has grown and grown and grown :-(
>
> It makes more sense to have the originating directory build a third variant
> of libpgport.a/libpgcommon.a containing modules built with $(CFLAGS_SL),
> and just link that into the shared library.  Unused files won't get linked,
> so the end result should be the same.
>
> This patch makes a down payment on that idea by having src/port/ build
> such a library and making libpq use it.  If the buildfarm doesn't expose
> fatal problems with the approach, I'll extend it to the other cases.
>

Looks like we have a bunch of failures, including prairiedog.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services