From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Piotr Stefaniak <postgres@piotr-stefaniak.me>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent
 run.
In-reply-to: <20170517211347.6g2bbx2fsjffd2sz@alvherre.pgsql>
References: <20170517211347.6g2bbx2fsjffd2sz@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Wed, 17 May 2017 17:13:47 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12242.1495058125.1@sss.pgh.pa.us>
Date: Wed, 17 May 2017 17:55:25 -0400
Message-ID: <12243.1495058125@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Piotr Stefaniak wrote:
>> If I remember correctly, it tries to right-align string literals to
>> whatever -l ("Maximum length of an output line") was set to.

> Yeah, it does that (for error messages too).

Piotr's version seems to at least do this more consistently than the
old version; for instance I notice this diff from Bruce's run:

@@ -1864,8 +1864,8 @@ describeOneTableDetails(const char *schemaname,
        if (verbose)
            printfPQExpBuffer(&buf,
                              "SELECT inhparent::pg_catalog.regclass,"
-                           "       pg_get_expr(c.relpartbound, inhrelid),"
-                         "     pg_get_partition_constraintdef(inhrelid)"
+                             "     pg_get_expr(c.relpartbound, inhrelid),"
+                             "     pg_get_partition_constraintdef(inhrelid)"
                              " FROM pg_catalog.pg_class c"
                              " JOIN pg_catalog.pg_inherits"
                              " ON c.oid = inhrelid"

(Again, untabified for clarity.)  However, it didn't do anything to any of
the horribly-formatted queries in pg_dump.c, so it's mostly following the
same rule as before.

> I'm not sure what's the behavior we do want.  One choice is that the
> continuation string opening quote should line up with the opening quote
> in the previous line.  So for instance:

Yeah, I'd vote for that one too.  If you want to line things up with
a function call paren, you can always start the whole literal on a fresh
line, as in the above example.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers