From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: pgsql-committers@postgresql.org,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Record full paths of programs sought by "configure".
In-reply-to: <51fca142-5ead-7f57-1798-2e02972b27c1@2ndQuadrant.com>
References: <E1dcE5n-0005Sk-UE@gemulon.postgresql.org>
 <d6ca14d4-a475-6496-48b6-d9f58b29a875@2ndQuadrant.com>
 <7295.1502133694@sss.pgh.pa.us>
 <90c39664-ec60-77dc-9f1b-21e8fa7b864c@2ndQuadrant.com>
 <10269.1502134598@sss.pgh.pa.us>
 <2a8e30d4-d584-1d74-6efa-100112062333@2ndQuadrant.com>
 <11702.1502136420@sss.pgh.pa.us>
 <51fca142-5ead-7f57-1798-2e02972b27c1@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Mon, 07 Aug 2017 16:15:11 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12320.1502137246.1@sss.pgh.pa.us>
Date: Mon, 07 Aug 2017 16:20:46 -0400
Message-ID: <12321.1502137246@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 08/07/2017 04:07 PM, Tom Lane wrote:
>> Sorry, I was imprecise.  What I'm suggesting is that you drop the
>> runtime PATH-foolery and instead put this in configure's environment:
>> 
>> PROVE=$perlpathdir/prove
>> 
>> Otherwise you're basically lying to configure about what you're going
>> to use, and that's always going to break eventually.

> Hmm, you're saying this should work now? OK, I'll try it when I get a
> minute to spare.

I'm pretty sure it's always worked, at least in the sense that you could
override what configure would put into Makefile.global that way.  I'm not
quite clear on whether providing an exact path to "prove" there is enough
to fix your problem.  If we have any places where we need to invoke the
corresponding version of "perl", then we have more things to fix.

>> Hm, yeah, the IPC::Run test would need to deal with this as well.
>> A PROVE_PERL environment variable is one way.  Or maybe simpler,
>> just skip the probe for IPC::Run if PROVE has been specified
>> externally; assume the user knows what he's doing in that case.

> WFM

OK, I'll go make that happen.

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers