From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework option set of vacuumlo
In-reply-to: <E1fudM8-0000af-Lm@gemulon.postgresql.org>
References: <E1fudM8-0000af-Lm@gemulon.postgresql.org>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 28 Aug 2018 12:44:24 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12437.1535488750.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 28 Aug 2018 16:39:10 -0400
Message-ID: <12438.1535488750@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Documentation and code is reordered to be more consistent. A basic set
> of TAP tests has been added while on it.

It'd be even better if these tests passed.  For me, not so much:

$ make check
...
t/001_basic.pl .. # Looks like your test exited with 2 before it could out=
put anything.
t/001_basic.pl .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 8/8 subtests =


Test Summary Report
-------------------
t/001_basic.pl (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 8 tests but ran 0.
Files=3D1, Tests=3D0,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.06 cusr =
 0.01 csys =3D  0.10 CPU)
Result: FAIL

and the log file says

# Running: oid2name --help
Command 'oid2name' not found in /home/postgres/testversion/bin, /home/post=
gres/t
estversion/bin, /usr/local/autoconf-2.69/bin, /home/postgres/bin, /usr/lib=
64/qt-
3.3/bin, /usr/lib64/ccache, /usr/local/bin, /bin, /usr/bin, /usr/local/sbi=
n, /us
r/sbin, /sbin at /home/postgres/pgsql/contrib/oid2name/../../src/test/perl=
/TestL
ib.pm line 414
# Looks like your test exited with 2 before it could output anything.

Similarly for the new vacuumlo tests.

This is also why the cfbot is unhappy.  Oddly, the buildfarm is not.
I think the reason why not is that the buildfarm does "make installcheck"
in contrib, and it first does "make install" in contrib, so that there's a
copy of oid2name to be found in the PATH.  But "make check" ought to be
testing the executable in the temporary installation tree, and it's not.

Digging, this is because the "make check" processing isn't actually
installing oid2name (resp. vacuumlo) into the temp installation tree :-(.

I don't think this is the fault of your tests, exactly --- there's
something wrong in the existing make rules.  I'm not sure what though.
EXTRA_INSTALL should be getting set, according to pgxs.mk:

temp-install: EXTRA_INSTALL+=3D$(subdir)

but it evidently isn't.

			regards, tom lane