Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.92)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1j7PHH-0002AH-F9
	for pgsql-committers@arkaria.postgresql.org; Thu, 27 Feb 2020 19:56:59 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1j7PHG-0004Dv-5x
	for pgsql-committers@arkaria.postgresql.org; Thu, 27 Feb 2020 19:56:58 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1j7PHF-0004Do-VE
	for pgsql-committers@lists.postgresql.org; Thu, 27 Feb 2020 19:56:57 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1j7PH9-0007qs-MC; Thu, 27 Feb 2020 19:56:57 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 01RJunDK012492;
	Thu, 27 Feb 2020 14:56:49 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <jdavis@postgresql.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Save calculated transitionSpace in Agg node.
In-reply-to: <E1j7Opv-0002yK-8q@gemulon.postgresql.org>
References: <E1j7Opv-0002yK-8q@gemulon.postgresql.org>
Comments: In-reply-to Jeff Davis <jdavis@postgresql.org>
	message dated "Thu, 27 Feb 2020 19:28:43 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <12490.1582833409.1@sss.pgh.pa.us>
Date: Thu, 27 Feb 2020 14:56:49 -0500
Message-ID: <12491.1582833409@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Jeff Davis <jdavis@postgresql.org> writes:
> Save calculated transitionSpace in Agg node.

Surely this patch is a few bricks shy of a load.  Don't you need
copyfuncs/readfuncs/outfuncs support, for starters?

			regards, tom lane