From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
cc: pgsql-hackers@lists.postgresql.org,
        =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@alvh.no-ip.org>,
        Sami Imseih <samimseih@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        Julien Rouhaud <rjuju123@gmail.com>
Subject: Re: Squash constant lists in query jumbling by default
In-reply-to: <Z-LZyygkkNyA8-kR@msg.df7cb.de>
References: <E1tubCw-0038AS-24@gemulon.postgresql.org>
 <Z-LZyygkkNyA8-kR@msg.df7cb.de>
Comments: In-reply-to Christoph Berg <myon@debian.org>
	message dated "Tue, 25 Mar 2025 17:28:59 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1282249.1742921593.1@sss.pgh.pa.us>
Date: Tue, 25 Mar 2025 12:53:13 -0400
Message-ID: <1282250.1742921593@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1282250.1742921593%40sss.pgh.pa.us>
Precedence: bulk

Christoph Berg <myon@debian.org> writes:
> For 2), Tom said that configurability is 1) often much less useful
> than originally planned, and 2) tools have to cope with both settings
> anyway, making implementing them harder. Plus, switching at run-time
> makes the result even less predictable.

To clarify that last bit: if some clients run with the GUC on and some
with it off, you have a mess.  Even statements that are completely
identical will have different query IDs under the two settings.

If this GUC sticks around, it should be at least PGC_SUSET (on
the analogy of compute_query_id) to make it harder to break
pg_stat_statements that way.

			regards, tom lane