From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: Peter Eisentraut <peter@eisentraut.org>,
        Masahiko Sawada <msawada@postgresql.org>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_logicalinspect: Fix possible crash when passing a
 directory p
In-reply-to: 
 <CAApHDvoOnd4PBNV0qyJVLmbWvWUjztzcMH5xY2AGp5Vov6XU3Q@mail.gmail.com>
References: <E1ts2ug-001xVQ-04@gemulon.postgresql.org>
 <CAApHDvqrhFfnetbcwgGkJ=z63T8HfQ_OyP=vX8BYiXyxFKt67w@mail.gmail.com>
 <6c00a8b2-0c40-44f0-b603-f6ae28b7694a@eisentraut.org>
 <CAApHDvqf4tKwE0oP8ybL2Eu-SD=C34pdZ9vVDSJwvqDXi88nUg@mail.gmail.com>
 <dc9665a8-987a-443d-ab18-f9865d21d034@eisentraut.org>
 <CAApHDvrFdXjbrV6KCx_GHKYSufUbNDYSsjppcJQiGOURfJE6qg@mail.gmail.com>
 <1244428.1752677780@sss.pgh.pa.us>
 <CAApHDvoOnd4PBNV0qyJVLmbWvWUjztzcMH5xY2AGp5Vov6XU3Q@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Thu, 17 Jul 2025 12:52:07 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1330025.1752722396.1@sss.pgh.pa.us>
Date: Wed, 16 Jul 2025 23:19:56 -0400
Message-ID: <1330026.1752722396@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1330026.1752722396%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> On Thu, 17 Jul 2025 at 02:56, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Looking again at the code for ereport_domain(), I wondered if
>> something like this would help MSVC see through it:

> I tried this and it unfortunately doesn't fix the issue.

I didn't have huge hopes for that, but thanks for checking.

> I spent a bit more time searching for a solution and did find
> something that works well enough for this case in [1]. Unfortunately,
> it only works with C11. See attached .c file and output below.

Hmph.  I doubt we are ready to require C11 everywhere, but maybe
we could require it in MSVC builds?  Which MSVC versions would
that eliminate?

			regards, tom lane