Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVf7j-0001EW-0W for pgsql-committers@arkaria.postgresql.org; Sat, 19 Mar 2022 19:52:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nVf7h-0000dW-Nv for pgsql-committers@arkaria.postgresql.org; Sat, 19 Mar 2022 19:52:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVf7h-0000dN-HI for pgsql-committers@lists.postgresql.org; Sat, 19 Mar 2022 19:52:25 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVf7f-0003DM-0l for pgsql-committers@lists.postgresql.org; Sat, 19 Mar 2022 19:52:25 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22JJqFiJ1340429; Sat, 19 Mar 2022 15:52:16 -0400 From: Tom Lane To: Andres Freund cc: Peter Geoghegan , pgsql-committers Subject: Re: pgsql: pgstat: run pgindent on pgstat.c/h. In-reply-to: <20220319194230.3lf5ghffngwxwrrf@alap3.anarazel.de> References: <20220319192715.tymn3rrg6qd6va5y@alap3.anarazel.de> <20220319194230.3lf5ghffngwxwrrf@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Sat, 19 Mar 2022 12:42:30 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1340427.1647719535.1@sss.pgh.pa.us> Date: Sat, 19 Mar 2022 15:52:15 -0400 Message-ID: <1340428.1647719535@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-03-19 12:36:29 -0700, Peter Geoghegan wrote: >> Ideally there would be some kind of reminder built into the >> pgindent tooling to make it less likely. > I think a lot of pgindent runs are just to reindent changes during > development, so that'd probably just join all the other stuff we learn to > ignore :) Yeah ... you can't do anything about it at the time you run pgindent, because you don't yet have the commit hash. So I don't see that such a reminder will help much. The pgindent/README file does mention that you ought to do this, so anyone following that recipe will get it right. regards, tom lane