Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1sv8mB-00Cj4H-L5
	for pgsql-committers@arkaria.postgresql.org; Mon, 30 Sep 2024 05:16:52 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1sv8mA-00CZQp-MR
	for pgsql-committers@arkaria.postgresql.org; Mon, 30 Sep 2024 05:16:50 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1sv8mA-00CZOm-Ek
	for pgsql-committers@lists.postgresql.org; Mon, 30 Sep 2024 05:16:50 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1sv8m7-001jui-Up
	for pgsql-committers@lists.postgresql.org; Mon, 30 Sep 2024 05:16:49 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 48U5GlEM1364410;
	Mon, 30 Sep 2024 01:16:47 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Show values of SET statements as constants in
 pg_stat_statements
In-reply-to: <E1sv8YF-001WMH-Ht@gemulon.postgresql.org>
References: <E1sv8YF-001WMH-Ht@gemulon.postgresql.org>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Mon, 30 Sep 2024 05:02:28 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1364408.1727673407.1@sss.pgh.pa.us>
Date: Mon, 30 Sep 2024 01:16:47 -0400
Message-ID: <1364409.1727673407@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/1364409.1727673407%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> Show values of SET statements as constants in pg_stat_statements

Shouldn't this have included a catversion bump?  The parsenodes.h
change would for example break new-style SQL functions that include
a SET command.  Probably a narrow use-case, but still.

			regards, tom lane