Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myIAH-0005l3-VN for pgsql-committers@arkaria.postgresql.org; Fri, 17 Dec 2021 18:41:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1myIAF-0007mT-Ce for pgsql-committers@arkaria.postgresql.org; Fri, 17 Dec 2021 18:41:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myIAF-0007mK-5m for pgsql-committers@lists.postgresql.org; Fri, 17 Dec 2021 18:41:07 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myIAB-00017E-0E for pgsql-committers@lists.postgresql.org; Fri, 17 Dec 2021 18:41:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1BHIf0vv1368840; Fri, 17 Dec 2021 13:41:00 -0500 From: Tom Lane To: Noah Misch cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas In-reply-to: <20211217182518.GA2529654@rfd.leadboat.com> References: <1363170.1639763559@sss.pgh.pa.us> <20211217182518.GA2529654@rfd.leadboat.com> Comments: In-reply-to Noah Misch message dated "Fri, 17 Dec 2021 10:25:18 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1368838.1639766460.1@sss.pgh.pa.us> Date: Fri, 17 Dec 2021 13:41:00 -0500 Message-ID: <1368839.1639766460@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Noah Misch writes: > On Fri, Dec 17, 2021 at 12:52:39PM -0500, Tom Lane wrote: >> It's sort of annoying to fire up a psql+backend >> for just one command, but perhaps there's other stuff that could be >> put there too. > Yes. The src/test/regress suite would be in a better place if one could run > most test files via a schedule containing only two files, the setup file and > the file of interest. Adding things like the "CREATE TABLE tenk1" to the > setup file would help that. If we're thinking of a generalized setup file, putting it after the tablespace test feels pretty weird. What was your motivation for doing this at the end of tablespace.source rather than the start? It doesn't look like that test in itself had any interesting dependencies on public not being writable. regards, tom lane