Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHmsm-0005Da-LI for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Feb 2022 13:19:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nHmsf-0003nC-Nk for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Feb 2022 13:19:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHfmh-00018Z-8O; Wed, 09 Feb 2022 05:44:55 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nHfmf-0004eM-59; Wed, 09 Feb 2022 05:44:54 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2195igXs1370503; Wed, 9 Feb 2022 00:44:42 -0500 From: Tom Lane To: Michael Paquier cc: Andrew Dunstan , Andres Freund , Tomas Vondra , pgsql-hackers@postgresql.org, pgsql-release@postgresql.org, Noah Misch , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR In-reply-to: References: <20220209004347.mnwaoiv5x7dntuvi@alap3.anarazel.de> <20220209014334.h5pyfbdh2to3v72j@alap3.anarazel.de> Comments: In-reply-to Michael Paquier message dated "Wed, 09 Feb 2022 11:24:21 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1370501.1644385482.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 09 Feb 2022 00:44:42 -0500 Message-ID: <1370502.1644385482@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > On Tue, Feb 08, 2022 at 05:43:34PM -0800, Andres Freund wrote: >> It's stamped, not tagged, so we could send out new tarballs. Or we coul= d skip >> a release number. IIRC we had to do something along those lines before. > It does not matter now, but the release is stamped and tagged. Yeah, I see no need to do anything about this on an emergency basis. >> What do you mean with detect here? > Well, we would not be able to see that something is stuck by default, > but Noah has just answered to my question by mentioning wait_timeout > in the buildfarm configuration. The buildfarm's wait_timeout option isn't that helpful here, because when it triggers, the client just goes belly-up *with no report*. So even if the CCA animals had it on, you'd not notice unless you started to wonder why they'd not reported lately. I think that's a bug that ought to be fixed. I do agree that wait_timeout ought to be finite by default, too. regards, tom lane