Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1hcVcP-0007cm-9U
	for pgsql-committers@arkaria.postgresql.org; Sun, 16 Jun 2019 13:54:49 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1hcVcO-0005Fy-1X
	for pgsql-committers@arkaria.postgresql.org; Sun, 16 Jun 2019 13:54:48 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hcVcN-0005Fr-KU
	for pgsql-committers@lists.postgresql.org; Sun, 16 Jun 2019 13:54:47 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hcVcK-0006I5-Dl; Sun, 16 Jun 2019 13:54:46 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x5GDsewZ013720;
	Sun, 16 Jun 2019 09:54:40 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
cc: Dean Rasheed <dean.a.rasheed@gmail.com>,
        Tomas Vondra <tomas.vondra@postgresql.org>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework the pg_statistic_ext catalog
In-reply-to: <20190616112021.2mncnuj26sbsbnzx@development>
References: <E1hcHz2-0005mY-5A@gemulon.postgresql.org>
 <8833.1560647898@sss.pgh.pa.us> <20156.1560650744@sss.pgh.pa.us>
 <CAEZATCWWX5O57d=MHY=MqyJe-xHG2pbi75LKLjo6aZLP3zsaow@mail.gmail.com>
 <20190616085651.d2hxuiqlojewed5j@development>
 <20190616100328.shl2hhuy2pup6ges@development>
 <20190616112021.2mncnuj26sbsbnzx@development>
Comments: In-reply-to Tomas Vondra <tomas.vondra@2ndquadrant.com>
	message dated "Sun, 16 Jun 2019 13:20:21 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <13718.1560693280.1@sss.pgh.pa.us>
Date: Sun, 16 Jun 2019 09:54:40 -0400
Message-ID: <13719.1560693280@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> Anyway, I'm wondering if we need the REVOKE/GRANT on pg_statistic_ext at
> all, and if we do if we should just remove the list of columns, and
> grant SELECT on all. All the sensitive columns were moved to another
> catalog, after all.

+1.  Per-column permissions checks seem pointlessly inefficient here.

> That also reminds me the patch should have revoked access to the new
> _data catalog.

Uh ... yeah.

			regards, tom lane