Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myJLt-0004BC-Bv for pgsql-committers@arkaria.postgresql.org; Fri, 17 Dec 2021 19:57:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1myJLr-0005XM-Vm for pgsql-committers@arkaria.postgresql.org; Fri, 17 Dec 2021 19:57:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myJLr-0005XD-Ot for pgsql-committers@lists.postgresql.org; Fri, 17 Dec 2021 19:57:11 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1myJLp-0001qn-LL for pgsql-committers@lists.postgresql.org; Fri, 17 Dec 2021 19:57:10 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1BHJv8lx1375352; Fri, 17 Dec 2021 14:57:08 -0500 From: Tom Lane To: Noah Misch cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas In-reply-to: <20211217194720.GB2529654@rfd.leadboat.com> References: <1363170.1639763559@sss.pgh.pa.us> <20211217182518.GA2529654@rfd.leadboat.com> <1368839.1639766460@sss.pgh.pa.us> <20211217194720.GB2529654@rfd.leadboat.com> Comments: In-reply-to Noah Misch message dated "Fri, 17 Dec 2021 11:47:20 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1375350.1639771028.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 17 Dec 2021 14:57:08 -0500 Message-ID: <1375351.1639771028@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Noah Misch writes: > On Fri, Dec 17, 2021 at 01:41:00PM -0500, Tom Lane wrote: >> If we're thinking of a generalized setup file, putting it after the >> tablespace test feels pretty weird. What was your motivation for >> doing this at the end of tablespace.source rather than the start? > I did it that way so a bit of the "make check" suite would exercise the > standard user experience. That's a minor concern, so putting the setup = file > before the tablespace file is fine. Various contrib and TAP suites will= still > test the standard user experience. Check. I'll make it so in a little bit. regards, tom lane