Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1eeUbc-0001ge-TU
	for pgsql-committers@arkaria.postgresql.org; Wed, 24 Jan 2018 23:37:25 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1eeUbc-00048N-8a
	for pgsql-committers@arkaria.postgresql.org; Wed, 24 Jan 2018 23:37:24 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eeUbc-00048D-0P
	for pgsql-committers@lists.postgresql.org; Wed, 24 Jan 2018 23:37:24 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1eeUbZ-0000vP-8R
	for pgsql-committers@postgresql.org; Wed, 24 Jan 2018 23:37:22 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w0ONbIih014030;
	Wed, 24 Jan 2018 18:37:18 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Thomas Munro <thomas.munro@enterprisedb.com>,
        pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Add parallel-aware hash joins.
In-reply-to: <20180124212916.aufzppm5bzg3oxav@alap3.anarazel.de>
References: <20171221092940.gbxcszbzsr5khsfr@alap3.anarazel.de>
 <20171221095550.d3e7xhoakcowhu5b@alap3.anarazel.de>
 <CAEepm=3eS6ra8oBCYsYYjPNsPqb2R_TaGQK8SGRFq_7gbP8RUg@mail.gmail.com>
 <CAEepm=0WxwzpHVHt3PcWHBV=L3k3FDb6dvMq1A2Li49LGBa7TA@mail.gmail.com>
 <20171222082203.fl6rpzlqnm4h7h6h@alap3.anarazel.de>
 <CAEepm=04WhyY65BpE2g_8E==ayhBXjV9JbyR-+9N4McmY3SQkQ@mail.gmail.com>
 <30219.1514428346@sss.pgh.pa.us>
 <CAEepm=1OyZcCAxAEWYhmeg0qmWyYF2O2yW7s7A4uVTt-dgRRyQ@mail.gmail.com>
 <4503.1514435195@sss.pgh.pa.us>
 <CAEepm=2rZ6NzdR7Rk5jsXsJR8M_kRmi+0JSY1x6DLSdmBb-=VA@mail.gmail.com>
 <20180124212916.aufzppm5bzg3oxav@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 24 Jan 2018 13:29:16 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <14028.1516837038.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 24 Jan 2018 18:37:18 -0500
Message-ID: <14029.1516837038@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2018-01-22 23:17:47 +1300, Thomas Munro wrote:
>> Here is a patch that halves the size of the test tables used.
>> ... Does this pass repeatedly on gaur?

> I'd say, let's just commit it and see?

Oh, sorry, I forgot I was on the hook to check that.  The news isn't
good: I got one pass, and then this on the second iteration:

*** /home/postgres/pgsql/src/test/regress/expected/join.out     Wed Jan 24=
 18:07:42 2018
--- /home/postgres/pgsql/src/test/regress/results/join.out      Wed Jan 24=
 18:26:53 2018
***************
*** 6122,6128 ****
  $$);
   initially_multibatch | increased_batches =

  ----------------------+-------------------
!  t                    | f
  (1 row)
  =

  rollback to settings;
--- 6122,6128 ----
  $$);
   initially_multibatch | increased_batches =

  ----------------------+-------------------
!  t                    | t
  (1 row)
  =

  rollback to settings;

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

			regards, tom lane