Date: Tue, 11 Nov 2014 19:26:48 -0700 (MST)
From: David G Johnston <david.g.johnston@gmail.com>
To: pgsql-committers@postgresql.org
Message-ID: <1415759208069-5826612.post@n5.nabble.com>
In-Reply-To: <E1XoMyc-0000gz-Uz@gemulon.postgresql.org>
References: <E1XoMyc-0000gz-Uz@gemulon.postgresql.org>
Subject: Re: pgsql: Message improvements
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

A couple of minor observations:

The new wording for this one seems worse off:

> incomplete read from reorderbuffer spill file: read %d instead of %u bytes

The "incomplete" aspect seems to be material...the proposed wording leads
one to believe the file is unreadable for some reason and then goes on to
say that bytes were read.

how about:

incomplete read of reorderbuffer spill file: read %d of expected %u bytes


> Writes full pages to WAL when first modified after a checkpoint, even for
> a non-critical modifications.

"... even for non-critical modifications." -- drop the "a" since
modifications is plural (or make it singular)

David J.


--
View this message in context: http://postgresql.nabble.com/pgsql-Message-improvements-tp5826611p5826612.html
Sent from the PostgreSQL - committers mailing list archive at Nabble.com.


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers