Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwYl2-0003ZW-6w for pgsql-committers@arkaria.postgresql.org; Mon, 25 Sep 2017 19:09:32 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dwYl0-0008IH-Ca for pgsql-committers@arkaria.postgresql.org; Mon, 25 Sep 2017 19:09:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dwYkk-0007Q6-Hf for pgsql-committers@postgresql.org; Mon, 25 Sep 2017 19:09:14 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dwYkh-00056K-MU for pgsql-committers@postgresql.org; Mon, 25 Sep 2017 19:09:14 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v8PJ9948014182; Mon, 25 Sep 2017 15:09:09 -0400 From: Tom Lane To: Peter Eisentraut cc: pgsql-committers@postgresql.org Subject: Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu In-reply-to: <862733d5-f132-a59b-7afb-86002f946f80@2ndquadrant.com> References: <862733d5-f132-a59b-7afb-86002f946f80@2ndquadrant.com> Comments: In-reply-to Peter Eisentraut message dated "Mon, 25 Sep 2017 14:51:44 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <14180.1506366549.1@sss.pgh.pa.us> Date: Mon, 25 Sep 2017 15:09:09 -0400 Message-ID: <14181.1506366549@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org Peter Eisentraut writes: > On 9/21/17 18:13, Tom Lane wrote: >> Give a better error for duplicate entries in VACUUM/ANALYZE column list. > In the error message, we should write "specified more than once" instead > of "specified twice", because that could otherwise look a bit silly: > VACUUM ANALYZE vaccluster(i,i,i); > ERROR: column "i" of relation "vaccluster" is specified twice OK. > (Also, the "is" doesn't seem to fit there.) Hm, reads fine to me, and I'd still rather include "is" in the revised wording. Anybody else agree with Peter's wording? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers