Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkpjE-0002XT-Da for pgsql-committers@arkaria.postgresql.org; Wed, 10 Nov 2021 15:41:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mkpjD-0002KI-3q for pgsql-committers@arkaria.postgresql.org; Wed, 10 Nov 2021 15:41:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkpjC-0002K9-T7 for pgsql-committers@lists.postgresql.org; Wed, 10 Nov 2021 15:41:34 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mkpjA-00066O-Hq for pgsql-committers@lists.postgresql.org; Wed, 10 Nov 2021 15:41:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1AAFfSt01440793; Wed, 10 Nov 2021 10:41:29 -0500 From: Tom Lane To: Peter Eisentraut cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Remove check for accept() argument types In-reply-to: References: Comments: In-reply-to Peter Eisentraut message dated "Tue, 09 Nov 2021 15:02:29 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1440791.1636558888.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 10 Nov 2021 10:41:28 -0500 Message-ID: <1440792.1636558888@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > Remove check for accept() argument types Early returns from the buildfarm are gaur | 2021-11-09 16:55:58 | auth.c:3235:17: warning: pointer ta= rgets in passing argument 6 of 'recvfrom' differ in signedness gaur | 2021-11-09 16:55:58 | pqcomm.c:722:9: warning: pointer ta= rgets in passing argument 3 of 'accept' differ in signedness gaur | 2021-11-09 16:55:58 | pqcomm.c:743:6: warning: pointer ta= rgets in passing argument 3 of 'getsockname' differ in signedness gaur | 2021-11-09 16:55:58 | pgstat.c:483:39: warning: pointer t= argets in passing argument 3 of 'getsockname' differ in signedness gaur | 2021-11-09 16:55:58 | pgstat.c:630:9: warning: pointer ta= rgets in passing argument 5 of 'getsockopt' differ in signedness gaur | 2021-11-09 16:55:58 | fe-connect.c:2760:11: warning: poin= ter targets in passing argument 5 of 'getsockopt' differ in signedness gaur | 2021-11-09 16:55:58 | fe-connect.c:2788:9: warning: point= er targets in passing argument 3 of 'getsockname' differ in signedness Right offhand I don't see any other animals complaining. May I suggest that "unsigned int" would be a better choice than "int" for socklen_t? regards, tom lane