Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYCxk-0007GW-Cg for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Mar 2022 20:24:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nYCxj-000374-7T for pgsql-hackers@arkaria.postgresql.org; Sat, 26 Mar 2022 20:24:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYCxi-00036v-Up for pgsql-hackers@lists.postgresql.org; Sat, 26 Mar 2022 20:24:38 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nYCxg-0007vh-RH for pgsql-hackers@lists.postgresql.org; Sat, 26 Mar 2022 20:24:37 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 22QKOWhC144621; Sat, 26 Mar 2022 16:24:32 -0400 From: Tom Lane To: Robert Haas cc: Andres Freund , Andrew Dunstan , PostgreSQL Hackers , Magnus Hagander Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. In-reply-to: References: <20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de> <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> Comments: In-reply-to Robert Haas message dated "Sat, 26 Mar 2022 16:03:24 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <144619.1648326272.1@sss.pgh.pa.us> Date: Sat, 26 Mar 2022 16:24:32 -0400 Message-ID: <144620.1648326272@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > On Sat, Mar 26, 2022 at 3:35 PM Andres Freund wrote: >> === tap tests in src/bin/pg_resetwal === >> t/001_basic.pl ...... ok >> t/002_corrupted.pl .. ok >> All tests successful. > Yeah, this certainly seems like an improvement to me. +1, but will it help for CI or buildfarm cases? regards, tom lane