Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8F3K-0005vu-W0 for pgsql-committers@arkaria.postgresql.org; Mon, 04 Jul 2022 05:55:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o8F3J-0005qS-Iv for pgsql-committers@arkaria.postgresql.org; Mon, 04 Jul 2022 05:55:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8F3J-0005qJ-BZ for pgsql-committers@lists.postgresql.org; Mon, 04 Jul 2022 05:55:21 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8F3E-0000mA-WF for pgsql-committers@lists.postgresql.org; Mon, 04 Jul 2022 05:55:20 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2645tDfS1467435; Mon, 4 Jul 2022 01:55:13 -0400 From: Tom Lane To: Peter Eisentraut cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8 In-reply-to: References: Comments: In-reply-to Peter Eisentraut message dated "Mon, 04 Jul 2022 05:38:57 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1467433.1656914113.1@sss.pgh.pa.us> Date: Mon, 04 Jul 2022 01:55:13 -0400 Message-ID: <1467434.1656914113@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > Change timeline field of IDENTIFY_SYSTEM to int8 Surely this patch is far from complete? To start with, just a few lines down in IdentifySystem() the column is filled using Int32GetDatum not Int64GetDatum. I will get some popcorn and await the opinions of the 32-bit buildfarm animals. But what about whatever code is reading the output? And what if that code isn't v16? I can't believe that we can make a wire protocol change as summarily as this. regards, tom lane