Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8F5N-00060N-OY for pgsql-committers@arkaria.postgresql.org; Mon, 04 Jul 2022 05:57:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o8F5M-0006yz-Bu for pgsql-committers@arkaria.postgresql.org; Mon, 04 Jul 2022 05:57:28 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8F5M-0006yq-5F for pgsql-committers@lists.postgresql.org; Mon, 04 Jul 2022 05:57:28 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8F5J-0000mq-EB for pgsql-committers@lists.postgresql.org; Mon, 04 Jul 2022 05:57:27 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2645vMbP1467769; Mon, 4 Jul 2022 01:57:22 -0400 From: Tom Lane To: Peter Eisentraut cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Change timeline field of IDENTIFY_SYSTEM to int8 In-reply-to: <1467434.1656914113@sss.pgh.pa.us> References: <1467434.1656914113@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Mon, 04 Jul 2022 01:55:13 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1467767.1656914242.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 04 Jul 2022 01:57:22 -0400 Message-ID: <1467768.1656914242@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I wrote: > To start with, just a few lines down in IdentifySystem() the column > is filled using Int32GetDatum not Int64GetDatum. I will get some > popcorn and await the opinions of the 32-bit buildfarm animals. Didn't need to wait long: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dflorican&dt=3D20= 22-07-04%2005%3A39%3A50 The other questions still stand. regards, tom lane