From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
cc: Heikki Linnakangas <hlinnaka@iki.fi>,
        Alexander Korotkov <akorotkov@postgresql.org>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Detecting pointer misalignment (was Re: pgsql: Implementation of
 subscripting for jsonb)
In-reply-to: 
 <CAPpHfdvmNwqEZajGsERi6y2Q7DRN892dPDt+WPTZqqsWDTFTZw@mail.gmail.com>
References: <E1l6Jjn-0000kp-75@gemulon.postgresql.org>
 <37bb56a0-391d-759d-771b-9c1d8c15a84b@iki.fi>
 <3293925.1612163110@sss.pgh.pa.us>
 <CAPpHfdsne3=T=fMNU45PtxdhSL_J2PjLTeS8rwKnJzUR4YNd4w@mail.gmail.com>
 <CAPpHfdu8Jh0tySa50Zhkyg6gMvi2pQFdHAMiF+UkZNqsDLwTQw@mail.gmail.com>
 <475514.1612745257@sss.pgh.pa.us> <477102.1612747200@sss.pgh.pa.us>
 <628089.1612802981@sss.pgh.pa.us>
 <CAPpHfdvmNwqEZajGsERi6y2Q7DRN892dPDt+WPTZqqsWDTFTZw@mail.gmail.com>
Comments: In-reply-to Alexander Korotkov <aekorotkov@gmail.com>
	message dated "Tue, 09 Feb 2021 03:35:01 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1477975.1613069167.1@sss.pgh.pa.us>
Date: Thu, 11 Feb 2021 13:46:07 -0500
Message-ID: <1477976.1613069167@sss.pgh.pa.us>
Precedence: bulk

Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Mon, Feb 8, 2021 at 7:49 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Ugh, no it isn't: even pretty recent clang releases only define
>> __GNUC__ as 4.  It looks like we need a separate test on clang's
>> version.  I looked at their version history and sanitizers seem
>> to have come in around clang 7, so I propose the attached (where
>> I worked a bit harder on the comment, too).

> Looks good to me.  Thank you for revising!

Were you going to push this, or did you expect me to?

			regards, tom lane