Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvRmQ-00007v-8W for pgsql-committers@arkaria.postgresql.org; Fri, 22 Sep 2017 17:30:22 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dvRmP-0007tm-OU for pgsql-committers@arkaria.postgresql.org; Fri, 22 Sep 2017 17:30:21 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dvRmP-0007t7-07 for pgsql-committers@postgresql.org; Fri, 22 Sep 2017 17:30:21 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dvRmL-0007Oa-Mn for pgsql-committers@postgresql.org; Fri, 22 Sep 2017 17:30:19 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v8MHUEjC014969; Fri, 22 Sep 2017 13:30:14 -0400 From: Tom Lane To: Andres Freund cc: pgsql-committers@postgresql.org Subject: Re: pgsql: Accept that server might not be able to send error in crash reco In-reply-to: References: Comments: In-reply-to Andres Freund message dated "Wed, 20 Sep 2017 04:42:08 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <14967.1506101414.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 22 Sep 2017 13:30:14 -0400 Message-ID: <14968.1506101414@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org Andres Freund writes: > Accept that server might not be able to send error in crash recovery test. piculet says you didn't cover all the bases: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dpiculet&dt=3D2017= -09-22%2017%3A10%3A01 Looks like you missed adding the "server closed the connection unexpectedly" alternative to one of the three places. regards, tom lane --=20 Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers