Feedback-ID: ie0a040ee:Fastmail
Message-ID: <14c9cb82-46e5-4be0-9233-36d09089dd11@eisentraut.org>
Date: Wed, 3 Jan 2024 13:14:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Follow-up fixes for "Make all Perl warnings fatal"
Content-Language: en-US
To: Andrew Dunstan <andrew@dunslane.net>,
 pgsql-committers@lists.postgresql.org
References: <E1rJLlz-00CYAB-5m@gemulon.postgresql.org>
 <b936521f-a79e-4ddd-d9a4-1864212d7bb1@dunslane.net>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <b936521f-a79e-4ddd-d9a4-1864212d7bb1@dunslane.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/14c9cb82-46e5-4be0-9233-36d09089dd11%40eisentraut.org>
Precedence: bulk

On 02.01.24 15:49, Andrew Dunstan wrote:
> 
> On 2023-12-29 Fr 17:56, Peter Eisentraut wrote:
>> Follow-up fixes for "Make all Perl warnings fatal"
>>
>> Mostly, we need to check whether $ENV{PG_TEST_EXTRA} is set before
>> doing regular expression matches against it.
> 
> 
> This reads a bit oddly to me.
> 
> -elsif ($ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)
> +elsif (!$ENV{PG_TEST_EXTRA} || $ENV{PG_TEST_EXTRA} !~ /\bkerberos\b/)
> 
> I think I would have changed it like this
> 
>    elsif (($ENV{PG_TEST_EXTRA" || "") !~ /\bkerberos\b/)
> 
> which is an idiom we've used elsewhere.

I would probably have written it that way, too, but there was already 
existing code dealing specifically with PG_TEST_EXTRA that was written 
the other way, so I made it match that.