Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNbJE-0008HO-1g for pgsql-committers@arkaria.postgresql.org; Thu, 02 Feb 2023 15:15:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pNbJC-0001u6-US for pgsql-committers@arkaria.postgresql.org; Thu, 02 Feb 2023 15:15:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNbJC-0001tg-N8 for pgsql-committers@lists.postgresql.org; Thu, 02 Feb 2023 15:15:30 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNbJA-0007Lq-Pf for pgsql-committers@lists.postgresql.org; Thu, 02 Feb 2023 15:15:30 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 312FFQpm1535542; Thu, 2 Feb 2023 10:15:26 -0500 From: Tom Lane To: Dean Rasheed cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Ensure that numeric.c compiles with other NBASE values. In-reply-to: References: Comments: In-reply-to Dean Rasheed message dated "Thu, 02 Feb 2023 09:44:52 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1535540.1675350926.1@sss.pgh.pa.us> Date: Thu, 02 Feb 2023 10:15:26 -0500 Message-ID: <1535541.1675350926@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Dean Rasheed writes: > Ensure that numeric.c compiles with other NBASE values. Looking at this diff made me wonder why the static pow10[] array isn't marked "const"? regards, tom lane