From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
In-reply-to: <315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com>
References: <E1iacW7-0003h6-6U@gemulon.postgresql.org>
 <13656.1575041267@sss.pgh.pa.us>
 <315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Fri, 29 Nov 2019 17:04:45 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <15398.1575043746.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 29 Nov 2019 11:09:06 -0500
Message-ID: <15399.1575043746@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2019-11-29 16:27, Tom Lane wrote:
>> Oooh ... some of the buildfarm members are pointing out that this
>> didn't follow a project convention:

> Um, yes, that's why it's in unsafe_tests.  Is there a way around this?

Sure, just change the test tablespace's name to follow the convention:

>> +WARNING:  tablespaces created by regression test cases should have nam=
es starting with "regress_"

I agree that this is somewhat pointless in the case of an "unsafe" test.
But using a different name isn't going to invalidate the test case,
so there's not really a reason to not follow the convention.  And
trying to have an exception for unsafe_tests seems like a lot more
trouble than it'd be worth.

			regards, tom lane