Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJqCW-0003Dj-Tn for pgsql-committers@arkaria.postgresql.org; Mon, 23 Jan 2023 06:21:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pJqCU-0005MQ-16 for pgsql-committers@arkaria.postgresql.org; Mon, 23 Jan 2023 06:21:02 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJqCT-0005MG-Qg for pgsql-committers@lists.postgresql.org; Mon, 23 Jan 2023 06:21:01 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJqCR-0005RS-2r for pgsql-committers@lists.postgresql.org; Mon, 23 Jan 2023 06:21:01 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30N6Ks1Z1540080; Mon, 23 Jan 2023 01:20:54 -0500 From: Tom Lane To: Michael Paquier cc: Andres Freund , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: instr_time: Represent time as an int64 on all platforms In-reply-to: References: Comments: In-reply-to Michael Paquier message dated "Mon, 23 Jan 2023 14:22:06 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1540078.1674454854.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 23 Jan 2023 01:20:54 -0500 Message-ID: <1540079.1674454854@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > On Sat, Jan 21, 2023 at 05:25:19AM +0000, Andres Freund wrote: >> instr_time: Represent time as an int64 on all platforms > hoverfly is unhappy since this went in: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dhoverfly&dt=3D= 2023-01-23%2005%3A01%3A44 Yeah, there was some discussion about that already: https://www.postgresql.org/message-id/20230121190303.7xjiwdg3gvb62lu3@awor= k3.anarazel.de I'm inclined to think that we should fix the plpython code to be rigorous about including everything else we need before including the Python headers. That's ugly, but it's not our fault that Python thinks it can redefine _POSIX_C_SOURCE. regards, tom lane