Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJqjn-0005d1-0g for pgsql-committers@arkaria.postgresql.org; Mon, 23 Jan 2023 06:55:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pJqjl-0001l8-Gm for pgsql-committers@arkaria.postgresql.org; Mon, 23 Jan 2023 06:55:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJqjl-0001kz-8o for pgsql-committers@lists.postgresql.org; Mon, 23 Jan 2023 06:55:25 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJqji-0006zh-V2 for pgsql-committers@lists.postgresql.org; Mon, 23 Jan 2023 06:55:24 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30N6tJVW1543365; Mon, 23 Jan 2023 01:55:19 -0500 From: Tom Lane To: Andres Freund cc: Michael Paquier , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: instr_time: Represent time as an int64 on all platforms In-reply-to: <20230123064647.tzxnmql2xkegc7sw@awork3.anarazel.de> References: <1540079.1674454854@sss.pgh.pa.us> <20230123064647.tzxnmql2xkegc7sw@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Sun, 22 Jan 2023 22:46:47 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1543363.1674456919.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 23 Jan 2023 01:55:19 -0500 Message-ID: <1543364.1674456919@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2023-01-23 01:20:54 -0500, Tom Lane wrote: >> Yeah, there was some discussion about that already: >> https://www.postgresql.org/message-id/20230121190303.7xjiwdg3gvb62lu3@a= work3.anarazel.de > I was thinking of starting a starting a separate thread about it - it's > mostly a plpython issue, the fact that my commit caused the compilation > failure is somewhat random. True. It also seems odd to me that per your analysis, we fixed the _POSIX_C_SOURCE conflict on 4 Aug 2011 and then broke it again on 18 Dec 2011, yet nobody has noticed for nigh a dozen years --- there has to be some other element in there. regards, tom lane