From: Tom Lane <tgl@sss.pgh.pa.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        "pgsql-committers@postgresql.org" <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Give a better error for duplicate entries in
 VACUUM/ANALYZE colu
In-reply-to: 
 <CAKFQuwZFg+kVbn_wt1Gqg_KM4XD1hAHpGN8wEgsyPiz72gB8HA@mail.gmail.com>
References: <E1dv9jI-0006oT-Fn@gemulon.postgresql.org>
 <862733d5-f132-a59b-7afb-86002f946f80@2ndquadrant.com>
 <14181.1506366549@sss.pgh.pa.us>
 <7eb88e2f-a6c9-82b3-6add-7794cf6197e9@2ndquadrant.com>
 <CAKFQuwZFg+kVbn_wt1Gqg_KM4XD1hAHpGN8wEgsyPiz72gB8HA@mail.gmail.com>
Comments: In-reply-to "David G. Johnston" <david.g.johnston@gmail.com>
	message dated "Mon, 25 Sep 2017 14:15:17 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1546.1506452995.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Tue, 26 Sep 2017 15:09:55 -0400
Message-ID: <1547.1506452995@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Mon, Sep 25, 2017 at 1:50 PM, Peter Eisentraut <
> peter.eisentraut@2ndquadrant.com> wrote:
>> On 9/25/17 15:09, Tom Lane wrote:
>>> Hm, reads fine to me, and I'd still rather include "is" in the
>>> revised wording.  Anybody else agree with Peter's wording?

>> Note a big deal.  I'm just working off existing error messages:

> ​About half of those, especially the "appears" ones, seem unhelpful for
> deciding whether to add "is" here; "is appears" just doesn't work.

Peter's evidence is pretty conclusive that using "is" is not consistent
with our message style precedents, but there's still room to choose
which precedent to follow ;-).

> The middle ground would be writing: column "i" of relation "vaccluster"
> appears more than once; I'm good with using appears instead of deciding
> between [is] specified.

Yeah, I like "appears more than once" too.  It does not leave one feeling
that "is" has been left out.  Also, "specified" seems like an
unnecessarily formal word here.  Per Mark Twain, "Don't use a five-dollar
word when a fifty-cent word will do."

I'll make this change in the back-patched patch, but Peter's list suggests
that it'd be worth trying to make a lot of these other usages more
consistent in HEAD.

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers