Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBH0O-0006u0-PY for pgsql-committers@arkaria.postgresql.org; Tue, 12 Jul 2022 14:36:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oBH0N-00064U-Iv for pgsql-committers@arkaria.postgresql.org; Tue, 12 Jul 2022 14:36:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBH0N-00062M-C7 for pgsql-committers@lists.postgresql.org; Tue, 12 Jul 2022 14:36:51 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBH0L-0001rF-8U for pgsql-committers@lists.postgresql.org; Tue, 12 Jul 2022 14:36:50 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26CEajwA1548312; Tue, 12 Jul 2022 10:36:45 -0400 From: Tom Lane To: Alvaro Herrera cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Add copy/equal support for XID lists In-reply-to: References: Comments: In-reply-to Alvaro Herrera message dated "Tue, 12 Jul 2022 14:12:49 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1548310.1657636605.1@sss.pgh.pa.us> Date: Tue, 12 Jul 2022 10:36:45 -0400 Message-ID: <1548311.1657636605@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alvaro Herrera writes: > Add copy/equal support for XID lists What about outfuncs/readfuncs? I see that you fixed _outList, but not its caller outNode: else if (IsA(obj, List) || IsA(obj, IntList) || IsA(obj, OidList)) _outList(str, obj); and the LEFT_PAREN case in nodeRead() doesn't know what to do either. regards, tom lane