Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s1eFC-00DnCp-OD for pgsql-committers@arkaria.postgresql.org; Tue, 30 Apr 2024 03:33:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s1eFA-003bpJ-5M for pgsql-committers@arkaria.postgresql.org; Tue, 30 Apr 2024 03:33:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s1eF9-003bpB-U9 for pgsql-committers@lists.postgresql.org; Tue, 30 Apr 2024 03:33:24 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s1eF8-000mWO-EZ for pgsql-committers@lists.postgresql.org; Tue, 30 Apr 2024 03:33:24 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 43U3XKjP1555831; Mon, 29 Apr 2024 23:33:20 -0400 From: Tom Lane To: David Rowley cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix test case from b0c5b215d. In-reply-to: References: <1539986.1714441226@sss.pgh.pa.us> <1544493.1714443268@sss.pgh.pa.us> Comments: In-reply-to David Rowley message dated "Tue, 30 Apr 2024 15:15:20 +1200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1555829.1714448000.1@sss.pgh.pa.us> Date: Mon, 29 Apr 2024 23:33:20 -0400 Message-ID: <1555830.1714448000@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk David Rowley writes: > On Tue, 30 Apr 2024 at 14:14, Tom Lane wrote: >> Yeah, the affected buildfarm members seem still not happy. > Isn't your latest fix adding COLLATE "C" to the wrong test? Oh! No, it was definitely adjusting a test that needed it, just not the only one :-(. Thanks for the fresh eyes. regards, tom lane