Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGaC2-00078l-14 for pgsql-committers@arkaria.postgresql.org; Mon, 12 Dec 2016 23:39:38 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cGaC1-0005qd-KI for pgsql-committers@arkaria.postgresql.org; Mon, 12 Dec 2016 23:39:37 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cGaBn-0005LT-PT for pgsql-committers@postgresql.org; Mon, 12 Dec 2016 23:39:23 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cGaBl-0003TJ-An for pgsql-committers@postgresql.org; Mon, 12 Dec 2016 23:39:22 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id uBCNdDCh015714; Mon, 12 Dec 2016 18:39:13 -0500 From: Tom Lane To: Petr Jelinek cc: Peter Eisentraut , pgsql-committers@postgresql.org Subject: Re: pgsql: Add support for temporary replication slots In-reply-to: <22907.1481571177@sss.pgh.pa.us> References: <27274.1481557380@sss.pgh.pa.us> <27833.1481558144@sss.pgh.pa.us> <62935e6f-4f1b-c433-e0fa-7f936a38b3e5@2ndquadrant.com> <22907.1481571177@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Mon, 12 Dec 2016 14:32:57 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <15712.1481585953.1@sss.pgh.pa.us> Date: Mon, 12 Dec 2016 18:39:13 -0500 Message-ID: <15713.1481585953@sss.pgh.pa.us> X-Pg-Spam-Score: -4.9 (----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org I wrote: > Petr Jelinek writes: >> Attached is the fixed test using the loop from test_extensions (and yes >> I would have missed the pg_stat_clear_snapshot() call without the hint, >> thanks :) ). > Pushed, thanks. Hm, buildfarm says this didn't fix it. Where exactly does the dropping of the slot happen ... is it not complete by the time the backend exits? regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers