From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Thomas Munro <thomas.munro@gmail.com>,
        =?iso-8859-1?Q?R=E9mi?= Zara <remi_zara@mac.com>,
        Michael Paquier <michael@paquier.xyz>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add kqueue(2) support to the WaitEventSet API.
In-reply-to: <20200224191453.GA711@alvherre.pgsql>
References: <20200224191453.GA711@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Mon, 24 Feb 2020 16:14:53 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <15885.1582572468.1@sss.pgh.pa.us>
Date: Mon, 24 Feb 2020 14:27:48 -0500
Message-ID: <15886.1582572468@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2020-Feb-24, Tom Lane wrote:
>> We could also consider a HINT, along the lines of "Raise the server's
>> max_files_per_process and/or \"ulimit -n\" limits."  This again has
>> the ambiguity about which server, and it also seems dangerously
>> platform-specific.

> Maybe talk about "the local server" to distinguish from the other one.

OK by me.

> As for the platform dependencies, I see two main options: make the hint
> platform-specific (i.e have #ifdef branches per platform) or make it
> even more generic, such as "file descriptor limits".

I thought about platform-specific messages, but it's not clear to me
whether our translation infrastructure will find messages that are
inside #ifdefs ... anyone know?  If that does work, I'd be inclined
to mention ulimit -n on non-Windows and just say nothing about that
on Windows.  "File descriptor limits" seems too unhelpful here.

			regards, tom lane