From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Peter Eisentraut <peter_e@gmx.net>, pgsql-committers@postgresql.org
Subject: Re: pgsql: Add transforms feature
In-reply-to: <20150427172712.GX4369@alvh.no-ip.org>
References: <E1YmNw0-0002Kb-3Q@gemulon.postgresql.org>
 <20150427172712.GX4369@alvh.no-ip.org>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
 message dated "Mon, 27 Apr 2015 14:27:12 -0300"
Date: Mon, 27 Apr 2015 21:05:47 -0700
Message-ID: <1602.1430193947@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Peter Eisentraut wrote:
>> Add transforms feature

> BF member olinguito is also failing the contrib test, because plpython
> is not compiled in that platform.

Yeah.  Even more specifically, olinguito does have --with-python in its
configure flags, but then the plpython Makefile skips the build because
libpython isn't available as a shared library.  But the contrib test is
(I assume, haven't looked) conditional only on the configure flag.

I'm not real sure now why we felt that was a good approach.  The general
project policy is that if you ask for a feature in the configure flags,
we'll build it or die trying; how come this specific Python issue gets
special treatment contrary to that policy?

So I'd vote for changing that to put the shared-library test in configure,
or at least make it a build failure later on, not "silently don't build
what was asked for".  That would mean olinguito's configure flags would
have to be adjusted.

Plan B would require propagating the shared-libpython test into the
contrib makefiles, which seems pretty unpalatable even if you're willing
to defend the status quo otherwise.

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers