Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Subject: Re: pgsql: Remove unused wait events.
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <4050629.1635182306@sss.pgh.pa.us>
Date: Mon, 25 Oct 2021 19:34:37 +0200
Cc: Robert Haas <robertmhaas@gmail.com>,
 Amit Kapila <akapila@postgresql.org>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <1611CCCC-E0E8-4A74-A95B-80ECCE987145@yesql.se>
References: <E1mdOBY-0005j2-QL@gemulon.postgresql.org>
 <CA+TgmoYSAsxiHqpyDCzJa2-hYv0Sme7Me1esi6sHG6LbY8KD+w@mail.gmail.com>
 <4047667.1635179918@sss.pgh.pa.us>
 <CA+TgmoZ2W5Pqq19kzN5K-Boveq0u1v5az7wFJcUhHdZ18aw7_A@mail.gmail.com>
 <4050629.1635182306@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1611CCCC-E0E8-4A74-A95B-80ECCE987145%40yesql.se>
Precedence: bulk

> On 25 Oct 2021, at 19:18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Robert Haas <robertmhaas@gmail.com> writes:
>> ... But while I agree it's good to remove unused stuff in the
>> master, it doesn't seem like we really need to back-patch it.
>=20
> Yeah, exactly.  I don't see any benefit that's commensurate with
> even a small risk of breaking extensions --- and apparently, in
> this case that's not a risk but a certainty.

Since this will cause integer values to have different textual enum =
value
representations in 14 and 15+, do we want to skip two numbers by =
assigning the
next wait event the integer value of WAIT_EVENT_WAL_WRITE incremented by =
three?
Or enum integer reuse not something we guarantee against across major =
versions?

--
Daniel Gustafsson		https://vmware.com/