From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Christoph Berg <myon@debian.org>, Robert Haas <robertmhaas@gmail.com>,
        Andres Freund <andres@anarazel.de>,
        Amit Kapila <amit.kapila16@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
In-reply-to: <9594.1578586797@sss.pgh.pa.us>
References: <E1in6ft-0004zR-6l@gemulon.postgresql.org>
 <20200103110128.GA28967@msg.df7cb.de> <13708.1578059577@sss.pgh.pa.us>
 <25771.1578249042@sss.pgh.pa.us> <20200106105608.GB18560@msg.df7cb.de>
 <3764.1578323719@sss.pgh.pa.us> <20200106191303.GA3975@msg.df7cb.de>
 <19973.1578351988@sss.pgh.pa.us> <28773.1578436137@sss.pgh.pa.us>
 <CA+TgmoZC_6z3d5+6n1GVfy898uoBHMPPJU4-nAQLG5ZkaEyqdQ@mail.gmail.com>
 <20200109145900.GF4192@msg.df7cb.de> <7656.1578585011@sss.pgh.pa.us>
 <72457f7b-4eed-c238-9e21-c113f793cf36@2ndquadrant.com>
 <9594.1578586797@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 09 Jan 2020 11:19:57 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <16327.1578606690.1@sss.pgh.pa.us>
Date: Thu, 09 Jan 2020 16:51:30 -0500
Message-ID: <16328.1578606690@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> I think he means something like
>> 	make check with_readline=no
>> not for the actual build.

> Oh, I see.  I'd rather not codify that though, because it risks
> problems if that symbol ever gets used any other way.  I was
> thinking of making the test script check for some independent
> environment variable, say SKIP_READLINE_TESTS.

I thought of another problem with the with_readline=no method,
which is that it requires the user to be issuing "make check"
directly; it wouldn't be convenient for a buildfarm owner, say.
(*Perhaps* it'd work to set with_readline=no throughout a
buildfarm run, but I think that's asking for trouble with the
build part.)  I pushed a patch using SKIP_READLINE_TESTS.
Christoph should be able to set that for the Ubuntu branches
where the test is failing.

			regards, tom lane