From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Add deduplication to nbtree.
In-reply-to: 
 <CAH2-WznRH9zmUn3tthVgHp3KDNvqCEL-E2u+xTgQYeT2xtfHqw@mail.gmail.com>
References: <E1j73sn-0003FQ-KO@gemulon.postgresql.org>
 <27003.1583087095@sss.pgh.pa.us>
 <CAH2-Wzn9_zQR9Q96JUyVBAdro52Ov6+bQ1zcE_FPxEVXGw-ebQ@mail.gmail.com>
 <29676.1583090977@sss.pgh.pa.us>
 <CAH2-WzmAufHiOku6AGiFD=81VQs5nYJ1L2YkhW1t+BH4CMsgRw@mail.gmail.com>
 <CAH2-Wz=Tz_e8e39qTs3Mt78P6XD9s3u7TdOUVrYZg2eTEgfB0w@mail.gmail.com>
 <5838.1583100843@sss.pgh.pa.us>
 <CAH2-WzkPR8KMwkL0ap976kmXwBCeukTeHz6fB-U__wvuP1S9Zg@mail.gmail.com>
 <CAH2-WznRH9zmUn3tthVgHp3KDNvqCEL-E2u+xTgQYeT2xtfHqw@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Sun, 01 Mar 2020 16:09:37 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1639.1583121984.1@sss.pgh.pa.us>
Date: Sun, 01 Mar 2020 23:06:24 -0500
Message-ID: <1640.1583121984@sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> On Sun, Mar 1, 2020 at 3:01 PM Peter Geoghegan <pg@bowt.ie> wrote:
>> I am happy to add parallel-to-_bt_form_posting() assertions about
>> alignment to _bt_form_posting(), to nail it down completely. Plus I'll
>> add the assertion I suggested already. Once I commit a patch with
>> these two new assertions, I think that we can consider the matter
>> resolved. Does that seem reasonable to you?

> I was thinking of the approach taken in the attached patch. It more or
> less copies over the assertions from _bt_form_posting() that did not
> appear in  _bt_update_posting().

OK by me.

			regards, tom lane